eval-view: migrate to JSDoc types and enable strict typecheck - #1345
Draft
paulirish wants to merge 9 commits into
Draft
eval-view: migrate to JSDoc types and enable strict typecheck#1345paulirish wants to merge 9 commits into
paulirish wants to merge 9 commits into
Conversation
TAG=agy CONV=b8464d5f-c6eb-4c16-a55f-18cf4758fd4d
TAG=agy CONV=b8464d5f-c6eb-4c16-a55f-18cf4758fd4d
TAG=agy CONV=b8464d5f-c6eb-4c16-a55f-18cf4758fd4d
TAG=agy CONV=b8464d5f-c6eb-4c16-a55f-18cf4758fd4d
TAG=agy CONV=b8464d5f-c6eb-4c16-a55f-18cf4758fd4d
- define canonical SuiteSummary and GuideSummary at boundary - eliminate @ts-expect-error on window global exports via evals.d.ts augmentation - use string literal unions for DataSource, SourceFilter, and GuideSortKey - add compile-time exhaustive never check on guide sort ladder - unify SuiteInfo in server.js to extend canonical SuiteSummary TAG=agy CONV=b8464d5f-c6eb-4c16-a55f-18cf4758fd4d
TAG=agy CONV=b8464d5f-c6eb-4c16-a55f-18cf4758fd4d
TAG=agy CONV=b8464d5f-c6eb-4c16-a55f-18cf4758fd4d
TAG=agy CONV=b8464d5f-c6eb-4c16-a55f-18cf4758fd4d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates the
eval-viewpackage from untyped JavaScript with@ts-nocheckto strictly type-checked JSDoc annotations without adding a build or bundling step.Changes
"strict": trueand"checkJs": trueineval-view/tsconfig.json, and added"typecheck"npm script to root monorepo.eval-view/(dashboard.js,landing.js,guide.js,eval-ui.js,dumbbell-chart.js,stability_trend.js,api.js,utils.js,summary-extractor.js,generate-mapping.js,generate-suites-list.js,server.js).SuiteSummaryandGuideSummarytypes insummary-extractor.jsand unifiedSuiteInfoacross server and client.Windowinevals.d.tsfor browser globals, eliminating@ts-expect-errorannotations on window exports.diffdevDependency to reference officialimport('diff').Changedefinitions.<feDropShadow>elements.