feat(harness): trajectory parsing and summary (1/3) - #1186
Conversation
711b9dc to
fc9f9e7
Compare
micahjo7
left a comment
There was a problem hiding this comment.
Wondering what kind of validation you've done on this logic? Could you share examples of the generated trajectory_summary.json files?
or, better would be to add tests (expand trajectory-parsing.test.ts, or split into separate tests <agent>-trajectory-parsing.test.ts) to make sure all the fields we want get populated correctly. It would be really great to actually invoke the agents with basic prompts and test the logic on those responses- then, we would catch any issues with model updates/variance of the produced trajectory files (which already happens quite often). This might be more overhead, could be added in the future if so.
|
One of my concerns is that we sort of have similar logic between our (Codex and Claude) trajectory HTML generation and now this parsing A question I have about what the desired output is in the dashboard's Is it feasible to just directly use the trajectory HTML files that we already generate there? |
i sent it in chat.
Well it's probably like possible to bring the two into alignment more. But... the cross-agent comparison wouldnt really work for this UI if we didnt rely on normalized step data. |
|
@psiarkiewicz if its fine with you ill take over these branches :) really appreciate these contributions! |
for sure! Thanks! |
|
btw I've consolidated the schema:
|
… code-mode, and patch filtering
|
super appreciate the thorough review! pushed an update that addresses all of this:
and handled the conflicts. oh so many conflicts. |
|
Oh right and I added type declaration files for claude and codex... had to develop them myself since the internet doesnt have them yet. but they're good. :) you're welcome, internet. |
micahjo7
left a comment
There was a problem hiding this comment.
just some small comments on the unused params. with this update the tests and callers will likely need to be updated too.
|
+78, -127! man that's a review from heaven. thank you! |
Summary
Part 1 of 3 (splitting #1010).
Introduces standardized trajectory parsing and auto-generates
trajectory_summary.json(schema v2.0) across all supported evaluation harness agents.generateNormalizedTrajectory()at the end of agent runs.