fix: replace uuid dependency with crypto.randomBytes - #1139
Open
piotrekwitkowski wants to merge 1 commit into
Open
fix: replace uuid dependency with crypto.randomBytes#1139piotrekwitkowski wants to merge 1 commit into
piotrekwitkowski wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Remove the uuid package to eliminate GHSA-w5hq-g745-h8pq (moderate severity, uuid <14.0.0). Uses crypto.randomBytes with manual UUID v4 formatting, compatible with Node 18+.
piotrekwitkowski
force-pushed
the
fix/remove-uuid-dependency
branch
from
April 29, 2026 02:31
bbb46ef to
c634b2d
Compare
|
Hi, I'm wondering if this is likely to get merged? I was going to submit a PR to bump |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uuidpackage from@lhci/cliand@lhci/serverto eliminate GHSA-w5hq-g745-h8pq (moderate severity, uuid <14.0.0)generateUUID()utility in@lhci/utils/src/uuid.jsusingcrypto.randomByteswith manual UUID v4 bit formattingcrypto.randomUUIDwhich requires Node 19+)Related
Test plan
yarn jest packages/server/test/api/storage/storage-method.test.jspassesyarn jest packages/utils/testpasses (pre-existing failures inbuild-context.test.jsare unrelated)