Skip to content

Remove @VisibleForTesting annotations in notifications code #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gdziadosz-google merged 2 commits into from
Aug 25, 2026
Merged

Remove @VisibleForTesting annotations in notifications code #618

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a579991
Remove annotation
Dp-Goog Aug 24, 2026
de27f8f
Clean
Dp-Goog Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions ...rowserhelper/src/main/java/com/google/androidbrowserhelper/trusted/NotificationUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
import android.content.pm.ServiceInfo;
import android.os.Build;
import android.os.Bundle;
import androidx.annotation.VisibleForTesting;
import androidx.core.app.NotificationManagerCompat;
import java.util.Locale;

Expand Down Expand Up @@ -55,7 +54,6 @@ public static boolean areNotificationsEnabled(Context context, String channelNam
/**
* Checks if high-priority notifications are configured in the manifest metadata.
*/
@VisibleForTesting
static boolean shouldUseHighPriorityNotifications(Context context) {
if (!(context instanceof Service)) return false;
try {
Expand Down Expand Up @@ -137,7 +135,6 @@ static void createNotificationChannelAndMaybeDeleteOldOne(Context context, Strin
* Generates a notification channel id from a channel name.
* TODO: Remove this when we can use the method defined in AndroidX instead.
*/
@VisibleForTesting
static String channelNameToId(Context context, String name) {
String baseId = name.toLowerCase(Locale.ROOT).replace(' ', '_');
return shouldUseHighPriorityNotifications(context)
Expand Down
Loading