Update DelegationService to override default notification channel creation for TWAs - #615
Merged
Conversation
Contributor
Author
|
@PEConn or @gdziadosz-google or @dtonderski-google , can anyone review this PR and help land this? This should be the last blocking thing needed for TWAs to support high priority notifications, thanks! |
Dp-Goog
force-pushed
the
main
branch
2 times, most recently
from
August 18, 2026 19:50
b1c0283 to
83bed85
Compare
PEConn
approved these changes
Aug 19, 2026
gdziadosz-google
requested changes
Aug 21, 2026
gdziadosz-google
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The earlier changes worked to create the high priority notification channel and delete the old notification channel if that existed. More investigation revealed that it was flaky, and the root cause is that the super class for AndroidX always posted to the default channel, even though it seemed like the code in NotificationUtils was actually creating the correct channel.
This PR fixes that by overriding
onNotifyNotificationWithChannel()by intercepting the notification, and manually setting a a high priority channel if the correct metadata exists. Verified manually using the test TWA that it works, with additional logging.