Adding AI harness with agent definitions, skills, and rules - #610
Draft
dmurph wants to merge 9 commits into
Draft
Conversation
Scaffold and bootstrap a complete AI Agent Harness at the project root. This includes: - Root entrypoint AGENTS.md with common building and testing rules. - Core rules for structure, style, testing, and dependency management. - Custom skills including doc-writer, code-review, and review. - Custom subagent definitions for reviewer and adversarial_reviewer. - Document templates and indexes for designs and execution plans. - Workspace registry files (.agents/) to activate the harness. TAG=agy CONV=394bc660-105e-4119-85b8-4032f5f278d3
Rename the `agents/` directory to `_agents/` to align with the convention for local project harnesses. Update all references, links, and inheritance paths: - Update AGENTS.md links. - Update .agents/ workspace registries to point to _agents/. - Update _agents/skills.json and _agents/agents.json registries. - Update templates (designs.md, plans.md) and skills (doc-writer, review, code-review, harness) configs. TAG=agy CONV=394bc660-105e-4119-85b8-4032f5f278d3
Create the dedicated `android-browser-helper_agent` subagent to act as the main assistant for this project. - Define `android-browser-helper_agent` config pointing to root AGENTS.md. - Register it in `_agents/agents.json`. - Update `_agents/GETTING_STARTED.md` with instructions for developers on how to run this agent. TAG=agy CONV=394bc660-105e-4119-85b8-4032f5f278d3
Remove the local `.agents/` configuration directory from Git tracking so that developers can make local modifications without affecting the repository. Add `/.agents/` to `.gitignore` to prevent it from being tracked in the future. TAG=agy CONV=394bc660-105e-4119-85b8-4032f5f278d3
Document the complete "Intended Developer Workflow" (Design -> Plan -> Implement -> Review -> Commit) adapted for the Android Browser Helper project. Document the manual onboarding steps required for developers to register skills and agents in their local `.agents/` directory (since it is gitignored). TAG=agy CONV=394bc660-105e-4119-85b8-4032f5f278d3
Remove `_agents/GETTING_STARTED.md` as the developer guide is redundant when using the pre-configured `android-browser-helper_agent` directly. TAG=agy CONV=394bc660-105e-4119-85b8-4032f5f278d3
…kills 1. Rename `adversarial_reviewer` to `design_reviewer` as it is a more standard term for the design review process. 2. Remove the `review` and `code-review` skills, which were redundant wrapper skills for starting subagents. Since subagents are registered in `agents.json`, the main agent can natively discover and invoke them for reviews without needing explicit skills defining the delegation routing. 3. Update `skills.json` and `agents.json` registries to reflect these removals and renames. 4. Update `doc-writer/SKILL.md` to reference the renamed `design_reviewer` for its GAN loop discriminator. TAG=agy CONV=394bc660-105e-4119-85b8-4032f5f278d3
Moves the raw Markdown rubric and formatting rules out of the subagent YAML configurations and into dedicated `code-review` and `design-review` skills. The subagent configs are drastically simplified to simply execute these skills, opening up the SOPs so they can also be read by humans or executed inline by the main agent without spawning a subagent. TAG=agy CONV=394bc660-105e-4119-85b8-4032f5f278d3
Update the `reviewer` and `design_reviewer` subagent configs to simply point to their respective skills. This finalizes the decoupling of the review SOP from the subagents themselves. TAG=agy CONV=394bc660-105e-4119-85b8-4032f5f278d3
dmurph
marked this pull request as draft
August 14, 2026 19:58
Author
|
moving to draft, needs work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an MVP with the structure, the documentation can be edited as we find AI to miss stuff or be over-prescriptive, etc.