Gas Reaction Chamber, Gas Entities & Gas Devourer#73
Open
BombasterDS2 wants to merge 3 commits into
Open
Conversation
Contributor
|
This pull request has been automatically marked as stale because it has not had You can always ask for help on our development discord. If you'd like to keep this open, just leave any comment, and the stale label will be removed. |
Author
|
Bot, don't close it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Added three new systems:
Gas Reaction Chamber
Changed logic of standard gas reactions - now GasReactionPrototypes have field that tells if reaction should commonly process (basic reactions). With this React method in AtmosphericSystem was changed to accept List of GasReactions as parameter (not breaking change).
This system will allow create machines that allow to make specific reactions and prohibid other reactoins.
Gas Entities
GasEntitiesSystem create FrozedDictionary inside it with ProtoIds of GasPrototypes as keys and spawned gas entities as values. This system allows creating gases with components (how it should work) without huge changes in current atmos systems.
Gas Devourer
Simple system that allows entity to consume gases near them and put mixture inside GasMixtureHolderComponent (so, entity required both GasDevourerComponnent and GasMixtureHolderComponent).
This component can be replaced with PortableScrubberComponent, but it requires huge logic change that will make code dirtier.
Requirements