Skip to content

fix: holistic review round 2 — TreeNodeResponse, CLI ingest, citation validation #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
egerev merged 1 commit into from
Apr 8, 2026
Merged

fix: holistic review round 2 — TreeNodeResponse, CLI ingest, citation validation #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/cli-go/internal/cmd/ingest.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,10 @@ func doIngest(content, sourceType string) error {
return err
}
body := map[string]string{
"content": content,
"text": content,
"source_type": sourceType,
}
data, err := c.Post("/ingest", body)
data, err := c.Post("/ingest/text", body)
if err != nil {
return err
}
Expand Down
4 changes: 3 additions & 1 deletion packages/core/alayaos_core/schemas/tree.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,12 @@
import uuid
from datetime import datetime

from pydantic import BaseModel, field_validator
from pydantic import BaseModel, ConfigDict, field_validator


class TreeNodeResponse(BaseModel):
model_config = ConfigDict(from_attributes=True)

id: uuid.UUID
path: str
node_type: str
Expand Down
3 changes: 3 additions & 0 deletions packages/core/alayaos_core/services/ask.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,11 @@ async def ask(
max_tokens=settings.ASK_MAX_OUTPUT_TOKENS,
)

# Collect valid IDs from all evidence (including chunk-sourced with entity_id/claim_id)
valid_entity_ids = {u.source_id for u in evidence if u.source_type == "entity"}
valid_entity_ids |= {u.entity_id for u in evidence if u.entity_id is not None}
valid_claim_ids = {u.source_id for u in evidence if u.source_type == "claim"}
valid_claim_ids |= {u.claim_id for u in evidence if u.claim_id is not None}
validated_citations = []
for c in response.citations:
if c.entity_id and c.entity_id not in valid_entity_ids:
Expand Down
Loading