Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stage the exact workflow authority needed to temporarily defer performance
comparison while functional tests and security checks continue unchanged.
This is the trust-only staging phase. It does not disable the benchmark job.
It adds one presence, seven action, and 28 command rows for the future benchmark
context, retaining every existing active and unrelated row:
1d47daeb93beb73266e0ae678db5e11df8f38a5e883d1ea50a4df5c55575d56dThe separately reviewed adoption adds a literal false condition and explanatory
comments to the existing Performance Benchmarks job. That would skip collection,
comparison, comments, artifacts, and baseline-cache updates. Performance would
be unassessed, not passed. The existing parser, six samples, 20% threshold,
action/command identities, permissions, and functional/security workflows remain
unchanged. Adoption must follow safe integration of this staging change;
promotion follows adoption. Neither later phase is included here.
Validation on this exact staging commit:
staged trust, restored adoption, and promotion from adopted trust.
command beneath the disabled job, and premature promotion.
action/command identities;
git diff --checkpasses.intentional constant-false condition. It was not suppressed or reported clean.
Keep this draft unmerged. Its original benchmark still runs and may retain
the known startup/baseline failure. A main push also currently starts snapshot
cleanup/publication, including release/tag deletion and GHCR publication. Those
effects need a separately established safe integration path. This PR changes no
release workflow, repository setting, credential, baseline data, or policy engine,
and does not waive branch requirements.