Repository navigation
fix: redact unknown Signal ref schemes - #23
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR tightens redaction of Signal/Workflow reference-like strings by replacing the previous “contains ://” heuristic with an explicit allowlist of known-safe ref schemes, and adds regressions to ensure scheme-shaped raw credential material is not echoed in service submit and operation outputs. It also bumps release metadata to v0.14.1.
Changes:
- Replace broad
://safe-ref detection with an explicit Signal/Workflow scheme allowlist (safeSignalRef→isAllowedSignalRef). - Add/adjust tests to ensure
foo://credential-raw-secret(and the raw fragment) are not present in marshaled outputs and that credential refs are redacted where expected. - Bump plugin/release metadata from
0.14.0to0.14.1.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| plugin.json | Bumps plugin version and release asset URLs to v0.14.1. |
| Makefile | Updates VERSION to 0.14.1 for builds/tests/releases. |
| internal/steps_service_operations_test.go | Adds regression assertions ensuring operation outputs redact scheme-shaped raw credentials. |
| internal/service_transport.go | Implements explicit allowlist-based ref scheme validation for redaction decisions. |
| internal/service_transport_test.go | Extends submit output redaction regression to cover scheme-shaped raw credential material. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
://safe-ref detection with an explicit Signal/Workflow ref scheme allowlistVerification
foo://credential-raw-secretleaks\n- go test ./internal -run 'ServiceLiveSubmitOutputRedactsRawInputs|ServiceOperationPrepareBuildsEnvelopeWithoutSubmit|ServiceOperationReportsAndAuditAreRedacted' -count=1\n- go test ./... -count=1\n- make pipeline-test\n- wfctl plugin validate-contract --for-publish --tag v0.14.1 .\n- goreleaser check\n- git diff --check