Repository navigation
feat: harden native Chrome product capture - #129
Merged
Merged
Conversation
Add crash-safe anonymous profile persistence, exact runtime conformance, bounded schema-validated provider inputs/outputs, and product-owned staging proof without OCI uploads.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- run product capture through native headed Chrome over CDP with a crash-safe anonymous retained profile\n- gate promotion on exact-image lifecycle, durable-cookie, pre-owner crash, and recovery conformance\n- validate bounded provider inputs/outputs against digest-pinned schemas and keep product-owned staging proof artifact-only (no OCI upload)\n\n## Verification\n- ok github.com/GoCodeAlone/workflow-plugin-product-capture 1.262s
? github.com/GoCodeAlone/workflow-plugin-product-capture/cmd/browser-runtime-conformance [no test files]
FAIL github.com/GoCodeAlone/workflow-plugin-product-capture/cmd/product-capture-provider [build failed]
FAIL github.com/GoCodeAlone/workflow-plugin-product-capture/cmd/product-capture-staging-proof [build failed]
? github.com/GoCodeAlone/workflow-plugin-product-capture/cmd/release-prep [no test files]
FAIL github.com/GoCodeAlone/workflow-plugin-product-capture/cmd/workflow-plugin-product-capture [build failed]
ok github.com/GoCodeAlone/workflow-plugin-product-capture/internal/conformance 8.555s
FAIL github.com/GoCodeAlone/workflow-plugin-product-capture/internal/plugin [build failed]
FAIL github.com/GoCodeAlone/workflow-plugin-product-capture/internal/provider [build failed]
ok github.com/GoCodeAlone/workflow-plugin-product-capture/internal/releaseprep 1.207s
ok github.com/GoCodeAlone/workflow-plugin-product-capture/internal/snapshot 1.608s
FAIL github.com/GoCodeAlone/workflow-plugin-product-capture/internal/stagingproof [build failed]
? github.com/GoCodeAlone/workflow-plugin-product-capture/schemas [no test files]
FAIL\n- \n- \n- \n- Linux/amd64 provider and Linux-only test binary compile\n- exact conformance: PASS on \n- 23 stable comparisons, zero mismatches, all five profile-persistence proofs true\n- independent adversarial review: SHIP-IT\n\n## Follow-up\nAfter merge, publish v0.1.66, bind workflow-compute staging to the immutable image digest, then run the product-owned staging proof before BMW commerce validation.