Repository navigation
Match migration image builder to required Go toolchain - #38
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Match the workflow-migrate image's Go builder to the module's exact required version: 1.26.4 to 1.26.5. Add a regression reading real go.mod metadata and the actual Dockerfile builder stage.
Scope Manifest
Approved ADR 0152 recovery: 25 tasks / 14 PRs, original outcomes retained.
This PR is Task 23 / PR 12, branch
fix/migration-image-toolchain-20261003.Workspace design/plan:
docs/plans/2026-10-02-workflow-compute-recovery-design.mdanddocs/plans/2026-10-02-workflow-compute-recovery-0a.md.Exactly two files. The existing ordered-runner review stays closed; no unrelated CLI/runtime feature. The failed draft v0.4.0 tag remains immutable.
Verification
WORKFLOW_MIGRATE_TEST_DSN: 10 packages / 156 cases / zero failures or skips, including real PostgreSQL and standalone public-runner consumer.Initial no-DSN run exposed the unchanged embedded-Postgres fallback sharing one runtime directory across packages; failed log retained and only the owned failing test stopped. A first local fixture startup was attempted before initdb finished and was not counted as a pass. After the isolated PostgreSQL cluster reported ready, the complete unchanged suite passed through the same DSN contract used by CI. Only that temporary cluster was stopped; no shared embedded/system database or Docker engine cleanup.
Runtime Launch Transcript
The original CLI has no
--versionorversioncommand; those probes correctly returned unsupported-command errors. No command was invented. Actual binary metadata and image identity verify the builder/platform; the local image is supporting evidence, not released provenance. Final help launch failure-signature scrape is clean. Owned proof containers were removed by exact IDs only; no engine restart/prune.Rollback
Do not retarget v0.4.0 or pin its failed image. After green exact-merge checks, publish and verify a new immutable successor before private-app consumption. No deployment/cloud mutation.