Repository navigation
Print explicit dirty state in migration status - #11
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Refactors the migration status command output into a helper function and ensures the “Dirty” state is always printed explicitly (true/false) so downstream tooling can reliably fail closed when status output is incomplete.
Changes:
- Extracted status rendering into a
writeStatus(io.Writer, interfaces.MigrationStatus)helper. - Updated the
statuscommand to write via Cobra’sOutOrStdout()and always printDirty: %t. - Added a unit test to assert
Dirty: true/falseis always present and that dirty state prints a warning.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/cli/root.go | Refactors status output into writeStatus and always prints explicit dirty state via the command’s writer. |
| pkg/cli/root_test.go | Adds coverage to ensure status output includes Dirty: true/false and emits a warning when dirty. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification