Repository navigation
fix(test): isolate released host version evidence - #197
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Task 27 / PR 16 adds bounded released-wfctl version diagnostics and isolates the native test fixture from optional background update notices. No production provider behavior, dependencies, workflows, policy files, credentials, or cloud resources change.
The admitted native v0.86.1 executable returned exit 0 with 92 stderr/combined bytes: its version plus a v0.86.2 update notice. Setting the documented
WFCTL_NO_UPDATE_CHECK=1in the existing allowlisted fixture environment removes the optional lookup. Strict raw combined-output equality, exact binary SHA/size admission, SDK/state/restart/replay checks, and cleanup requirements remain intact. This local reproduction does not recover the lost output of merged CI run 37212700162.Verification
go test -race ./... -count=1, native proof enabled: six test packages pass, two packages have no tests.go build ./...,go vet ./..., format and diff checks pass..github, go.mod and go.sum are unchanged.TMPDIR=/private/tmp: the longer default temporary parent produced a separate plugin-handshake failure after version admission. This disclosed harness boundary is not a product fix or a hosted CI success claim.One initial adversarial code review and the opt-out-only closure found no warranted Important/Critical issue. Final restored flag and source hashes were independently checked by the lead. Hosted exact-head CI and normal protected merge remain required.
Scope
Design: https://github.com/GoCodeAlone/workspace/blob/docs/workflow-compute-recovery-0a-closeout-20261002/docs/plans/2026-10-02-workflow-compute-recovery-design.md
Plan: https://github.com/GoCodeAlone/workspace/blob/docs/workflow-compute-recovery-0a-closeout-20261002/docs/plans/2026-10-02-workflow-compute-recovery-0a.md
PR Count: 16
Tasks: 27
Status: Locked 2026-10-04T20:02:20Z
ADR 0160 authorizes only this source-only slice. No DigitalOcean token/API access, provisioning, deployment, spend, protection bypass or policy relaxation. Immutable v2.1.19 is not retargeted. Original recovery and slimming gates remain open; any necessary successor and consumer-pin reconciliation follow verified merge/release.
Doc-reconciliation: clean.