Repository navigation
feat: add compute container runtime adapters - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TDD / verification
RED examples observed before fixes:
GOWORK=off go test ./container -run TestSandbox -count=1failed with undefined adapter APIsGOWORK=off go test ./container -run TestRuntimeAdapterContracts -count=1failed with undefined contract buildersGOWORK=off go test ./container -run 'Test(ContainerBuildRejectsReservedControlEnvOverride|ContainerBuildPassesAllTagsAsJSON|CommandArtifactHashRejectsSymlinkPathComponents)' -count=1failed for accepted reserved env, missing WORKFLOW_COMPUTE_BUILD_TAGS, and symlink artifact traversal\n\nGREEN after implementation:\n-GOWORK=off go test ./... -count=1\n-GOWORK=off go vet ./...\n-GOWORK=off go build ./...\n-wfctl plugin validate-contract .\n\n## Notes\nwfctl plugin validate-contractcurrently recognizes module/step/trigger/service_method/message contract kinds only. Runtime adapter discovery is therefore exposed viaruntimeAdaptersRefrather than an unknownplugin.contracts.jsonkind.\n\nPart of workflow-compute RTE-1 / T520. Host-only task admission, leases, authz, credential resolution, registry allowlists, proof/reward mutation, and worker binding remain outside the plugin.