Repository navigation
Allow explicitly declared preview query targets - #39
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An explicitly approved preview link such as
/contact?interest=voice-studycannot use scoped viewing because the current gate rejects every query. Add an optional finite per-tenantPreviewAccessQueryTargetsceiling, derived from validated host declarations. Only exact listed queried GET/HEAD targets can reach the existing callback; nil/default configuration continues rejecting queries.Privately copy and validate the declarations. Reject encoded aliases, duplicate/unsorted keys, empty values, fragments, privileged paths and unbounded targets. The callback still verifies the complete target, exact tenant/origin/audience and current grant. Keep transport, bcrypt, Basic authentication, current domain ownership, credential stripping and private/no-store/noindex behavior.
Actual Gate tests cover exact GET/HEAD delivery with the original query preserved, absent/unlisted/other-tenant authority, malformed/framing/method requests, current callback revocation, immutable declarations and startup refusals. Existing strict no-query tests remain unchanged in behavior. Local verification is formatting and
git diff --check; ordinary exact-head CI and independent source review are required before merge. No local Go/Docker/build, credential/grant/schema or hosted action occurred.This follow-up is based on the actual CMS38 merged main
b49dba3f5b8617cc71f8cc6a5c510d49a4e7de18. It grants no access by itself and needs matched Auth/current-grant and host target binding. Include the reviewed passing follow-up in the next stable CMS release before host adoption.