Repository navigation
chore: bump SDK to workflow v0.51.2 - #10
Merged
Merged
Conversation
- go.mod: workflow v0.19.0 → v0.51.2 - plugin.json: minEngineVersion 0.19.0 → 0.51.2 - ci.yml: add WFCTL_VALIDATE_VERSION env, plugin-contracts job with setup-wfctl@SHA + strict-contracts validate; drop master branch trigger - grpc-version-sync.yml: added (grpc v1.80.0 matches workflow v0.51.2) - internal/contract_smoke_test.go: factory smoke test (no t.Skip) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Bumps this plugin’s Workflow SDK dependency to github.com/GoCodeAlone/workflow v0.51.2 as part of the plugin cutover wave, updates the plugin manifest’s required engine version, and adds CI gates to keep strict-contract validation and gRPC versions aligned with the pinned Workflow release.
Changes:
- Update
minEngineVersionto0.51.2and bumpgithub.com/GoCodeAlone/workflowtov0.51.2. - Refresh transitive Go module dependencies (
go.mod/go.sum) consistent with the new Workflow version. - Update CI workflows and add a new gRPC version lockstep workflow.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| plugin.json | Raises required engine version to 0.51.2. |
| internal/contract_smoke_test.go | Adds a new smoke test around plugin instantiation. |
| go.mod | Bumps Workflow dependency to v0.51.2 and updates indirect deps. |
| go.sum | Updates module checksums for the new dependency graph. |
| .github/workflows/grpc-version-sync.yml | Adds CI gate to compare plugin grpc-go version vs Workflow release artifact. |
| .github/workflows/ci.yml | Updates CI triggers/actions and adds strict contract validation job via wfctl. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- contract_smoke_test.go: add reflect typed-nil guard and concrete type-assert (F-A1) - ci.yml: derive wfctl version from go.mod instead of hardcoded env var (F-A2) - grpc-version-sync.yml: fail explicitly when grpc= line missing from artifact (F-A3) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plugin cutover wave; applies pattern from workflow-plugin-payments v0.4.1 pilot. See BMW docs/plans/2026-05-11-plugin-cutover-wave-design.md.