Repository navigation
fix(workflow-compat): allow_no_entry_points on module-only testdata - #16
Merged
Merged
Conversation
The workflow-compat job runs `wfctl validate` against this testdata to verify backward-compat for `step.audit.poll_anchor_confirmation` and `step.audit.public_receipt` under STRICT_PROTO. The config is module-only (audit.ledger + audit.anchor_provider.opentimestamps) with no entry points — a recent wfctl tightening (config-must-have-entry-points) started rejecting these embeddable-style configs. Add `allow_no_entry_points: true` per the engine's documented escape hatch for embeddable sub-workflows / module-only validation fixtures. Unblocks workflow-compat CI on PRs touching this repo. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…(not YAML field)
Prior commit added `allow_no_entry_points: true` to the testdata YAML, but
that key isn't a config field — wfctl parses it as CLI flag
`--allow-no-entry-points`. Revert the YAML change; add the flag to the
wfctl validate invocation in .github/workflows/workflow-compat.yml instead.
Engine reference: `cmd/wfctl/validate.go:22` defines
fs.Bool("allow-no-entry-points", false, "Allow configs with no entry
points (triggers, routes, subscriptions, jobs)")
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent wfctl tightening (config must have entry points) started rejecting the module-only
testdata/compat-strict-proto-config.yamlfixture, breaking workflow-compat CI on every PR. Fix: addallow_no_entry_points: trueper the engine's documented escape hatch for embeddable / module-only validation fixtures.