Skip to content

chore: apply plugin version discipline - #21

Merged
intel352 merged 4 commits into
masterfrom
issue-760-version-discipline
Jun 1, 2026
Merged

intel352 merged 4 commits into
masterfrom
issue-760-version-discipline

Conversation

@intel352

@intel352 intel352 commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Part of GoCodeAlone/workflow#760.

Changes:

  • keep committed plugin.json.version at the 0.0.0 development sentinel
  • remove the obsolete sync-plugin-version workflow when present
  • add post-build release validation so the shipped manifest is checked against the tag
  • preserve/strengthen runtime capability checks where needed

Verification:

  • wfctl plugin validate-contract .
  • wfctl plugin validate-contract --for-publish --tag v9.9.9 .
  • GOWORK=off go test ./...

Copilot AI review requested due to automatic review settings June 1, 2026 18:12

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR tightens plugin versioning and release-time validation for workflow-plugin-agent, shifting the source tree to a development-sentinel manifest version while ensuring release artifacts are validated against the tag.

Changes:

  • Adds a GoReleaser-driven build that injects a build version and packages plugin.json + strict contract metadata.
  • Sets committed plugin.json version to 0.0.0 and adds release workflow checks (validate-contract, verify-capabilities) before/after building.
  • Adds an external-plugin host binary entrypoint (cmd/workflow-plugin-agent) and a build-time Version variable.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
version.go Introduces a build-time-injected Version variable for release builds.
plugin.json Resets committed manifest version to the 0.0.0 development sentinel and reformats capability arrays.
plugin.go Updates in-code plugin manifest/version fields and adds an external SDK Manifest() method for hosting.
cmd/workflow-plugin-agent/main.go Adds an external-plugin protocol host that serves the plugin with a resolved build version.
.goreleaser.yml Enables building/archiving and injects both Go build version and release plugin.json version via a pre-build hook.
.github/workflows/release.yml Adds pre-/post-build contract validation and a runtime capability verification step.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread plugin.go Resolved
Copilot AI review requested due to automatic review settings June 1, 2026 18:19

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Comment thread .github/workflows/release.yml Resolved
@intel352
intel352 merged commit 6132f8e into master Jun 1, 2026
5 checks passed
@intel352
intel352 deleted the issue-760-version-discipline branch June 1, 2026 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants