Repository navigation
feat(accountkeys): add upstream SVR and MFA parity - #37
Merged
Merged
Conversation
Preserve legacy key derivations while matching upstream authenticated metadata and PIN master-key formats. Reject malformed wire input and redact SVR keys across formatting and logging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Port the additive upstream v0.104.0 account-key and MFA metadata contract to pure Go:
SVRKeywith registration lock, recovery, storage-service and logging derivations; preserveDeriveSVRKey() [32]byte.No service/network APIs, raw SVR getter, release tag, or whole-protocol v0.104.0 claim. The global compatibility baseline remains v0.96.4 pending the consolidated refresh.
Scope
Approved workspace umbrella:
docs/plans/2026-07-10-signal-spaces-group-channels.md.PR Count: 34. Tasks: 41. Locked: 2026-10-03T08:47:45Z.
This PR completes only Task 31. Encrypted Spaces proof work is explicitly deferred by ADR 0150; no proof optimization resumes. Protocol/SPQR work and the consolidated release remain separate PR boundaries.
Upstream Evidence
signalapp/libsignal v0.104.0.03b9987415e6dcb3d83dfde6a16b52d2b59a7b44.257105c55a7389ca6b1e85185e2769465e6729f1.06959b4708f9b7b1e94d0f8cc835f3958c077e94; libcrux-ml-kem exactly 0.0.10.rust-objcopy/missinglibLLVM.dylibwarning; compilation, tests, vector replay, and CLI interop still exit 0. No system toolchain configuration was modified.Verification
CGO_ENABLED=0 go build ./...,go vet ./..., lint: 0 issues.Regression Proof
With authentication/redaction deliberately bypassed:
TestMFAMetadataRoundTripAndTampering: FAIL, tampered MAC byte 128 returned metadata.TestPinHashMasterKeySIV: FAIL, tampered byte 0 returned plaintext.TestSVRDerivationsAndRedaction: FAIL, formatting/logging leaked the public test canary.With protections restored: all three PASS. Authenticated overlong protobuf tag/length tests also fail before the bounds fix and pass after it.
Runtime Launch Transcript
Build:
CGO_ENABLED=0 go build ./...exits 0.Launch: a tiny downstream consumer imports the actual
accountkeyspackage and usescrypto/rand.Reader; no library stubs.Failure-signature scrape: clean. Verdict: PASS.
Doc-reconciliation: clean; current oracle pin and inherited compatibility baseline are explicitly distinguished.