Repository navigation
Fix portable Encrypted Spaces release builds - #2
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR makes the release pipeline portable across supported runner architectures by building the real RISC Zero guest methods once on a supported host, packaging them into a checksum-verified bundle, and reusing that bundle to embed identical guest binaries/IDs into all native release assets. It also strengthens release attestations by adding an explicit predicate that binds the published artifacts back to the originating release SHA/run/ref.
Changes:
- Adds a “guest-methods” job to build/normalize/verify guest methods once, then downloads & verifies that bundle in native asset jobs before embedding it.
- Introduces shared Rust build-script helper (
prebuilt_guest.rs) and a Python bundle tool to create/verify an architecture-independent guest bundle. - Enhances publisher workflow attestations to include both provenance and an explicit “release source binding” predicate.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
PATCHES.md |
Updates the upstream-delta ledger to reflect the new guest-bundle + attestation approach. |
ffproof/tracer/methods/build.rs |
Adds prebuilt guest embedding support before falling back to risc0_build::embed_methods(). |
ffproof/prebuilt_guest.rs |
New helper for copying prebuilt methods.rs into OUT_DIR and exporting the bundle path to rustc. |
ffproof/methods/build.rs |
Uses the prebuilt-guest embedding helper when available. |
ffproof/client_methods/build.rs |
Uses the prebuilt-guest embedding helper when available. |
bridge/tests/runtime.rs |
Extends release-contract tests and adds bundle-tool integration tests. |
.github/workflows/release-publish.yml |
Adds an explicit source-binding predicate attestation alongside provenance. |
.github/workflows/release-bridge.yml |
Adds “guest-methods” job and updates asset/gate jobs to download+verify+embed the guest bundle (and provision protoc). |
.github/scripts/prepare-encrypted-spaces-guest-bundle.py |
New tool to create/verify a strict guest bundle (manifest + SHA256SUMS + normalized methods.rs). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Reject manifest symlinks before reading their targets, including when the checksum manifest omits manifest.json.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
protoc, keep the RISC Zero install token scoped to the install step, and prove the packaged Linux backend without build-only RISC Zero toolsFailure addressed
Main release run
29244296832showed that RISC Zero 3.0.5 publishescargo-risczeroonly for Linux amd64 and macOS arm64, while the supported hosts that reached compilation lackedprotoc. The native jobs no longer install unavailable guest toolchains.Verification
cargo test -p encrypted-spaces-bridge --locked -- --test-threads=1(55 passed, 1 real-proof release test ignored)RISC0_SKIP_BUILD=1 RISC0_DEV_MODE=1 cargo clippy --workspace --all-targets --locked -- -D warningscargo fmt --all -- --checkpython3 -m py_compile .github/scripts/prepare-encrypted-spaces-guest-bundle.pyactionlint .github/workflows/release-bridge.yml .github/workflows/release-publish.ymlRegression proof
With the manifest path validation reverted:
With the fix restored:
The hosted main release run remains the authoritative real guest build, packaged real-proof, and four-platform asset gate.