Repository navigation
Add brainstorm visual companion guidance - #99
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a host-neutral “Visual Companion” workflow to the brainstorming skill so agents can offer diagrams/mockups just-in-time (with text fallback and privacy rules), and backs it with fixtures, regression guards, and durable documentation/decision records.
Changes:
- Extend
skills/brainstorming/SKILL.mdwith Visual Companion offer/use/fallback/staleness rules and lazy-loaded guidance. - Add a bounded
visual-companion.mdguide plus expected-behavior fixture and a focused regression test. - Update coverage matrices, follow-ups, and planning/ADR artifacts to document scope (browser/event capture explicitly deferred) and evidence.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/cross-llm-coverage.md | Updates brainstorming coverage notes to include visual companion guidance and deferrals. |
| tests/brainstorm-visual-companion.sh | Adds regression guard asserting required Visual Companion markers/docs/fixtures and capability-row constraints. |
| skills/brainstorming/visual-companion.md | Adds lazy-loaded guide with examples, accessibility/text fallback, and no-secrets/PII rules. |
| skills/brainstorming/test-fixtures/visual-companion/expected-behavior.md | Adds fixture defining RED baseline + expected compliant paths (offer/decline/accept/stale). |
| skills/brainstorming/SKILL.md | Introduces Visual Companion step + dedicated section and integrates into the process flow. |
| docs/plans/2026-06-30-brainstorm-visualization.md | Implementation plan describing scope, tasks, tests, and proof protocol. |
| docs/plans/2026-06-30-brainstorm-visualization-plan-review.md | Captures adversarial plan review and resolutions. |
| docs/plans/2026-06-30-brainstorm-visualization-design.md | Design doc defining parity boundary, host capability matrix, and failure rules. |
| docs/plans/2026-06-30-brainstorm-visualization-design-review.md | Captures adversarial design review and resolutions. |
| docs/plans/2026-06-30-brainstorm-visualization-behavior-proof.md | Records RED baseline + GREEN subject/reviewer behavior proof and evidence. |
| docs/FOLLOWUPS.md | Adds durable follow-up for deferred browser/click-event parity work. |
| docs/cross-llm-coverage.md | Adds Visual Companion capability row and notes about best-effort rendering + deferrals. |
| decisions/0005-visual-companion-instructions.md | ADR documenting decision, alternatives, and consequences. |
| AGENTS.md | Documents the new focused test in the recommended validation suite. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| | Host declaration for skill conditionals | `Host: claude-code` in CLAUDE.md | `Host: codex` in `~/.codex/AGENTS.md` | `Host: opencode` in `~/.config/opencode/AGENTS.md` | n/a | Auto-detected as `hermes-agent` | `Host: zed-agent` in `~/.config/zed/AGENTS.md` or `%APPDATA%\\Zed\\AGENTS.md` | | ||
| | Skill discovery path (user scope) | `~/.claude/skills/` (personal skills); autodev installed to `~/.claude/plugins/marketplace/autodev/` via marketplace | `~/.agents/skills/` | `~/.config/opencode/skills/` | via plugin (no manual symlink) | `~/.hermes/skills/` (symlink or `hermes skills install`) | `~/.agents/skills/<skill-name>/` (flat; no namespace folder) | | ||
| | Model tier vocabulary | role names → `haiku`/`sonnet`/`opus` (see `agents/model-tiers.md`) | role names → `gpt-5.4-mini`/`gpt-5.4`/`gpt-5.5` | role names → host-pass-through | role names → host-pass-through | role names → host-pass-through | role names → host-pass-through | | ||
| | Visual companion output | ⚠️ markdown/Mermaid best-effort; browser deferred | ⚠️ markdown/Mermaid best-effort; browser deferred | ⚠️ markdown/Mermaid best-effort; browser deferred | ⚠️ markdown/Mermaid best-effort; browser deferred | ⚠️ markdown/Mermaid best-effort; browser deferred | ⚠️ markdown plus best-effort Mermaid rendering; browser deferred | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skills/brainstorming/SKILL.mdfor mockups, Mermaid diagrams, architecture maps, and layout comparisons.skills/brainstorming/visual-companion.mdguide with text fallback, accessibility, stale-visual, and no-secrets/PII rules.Closes #78.
Design
See:
docs/plans/2026-06-30-brainstorm-visualization-design.mdADR:
decisions/0005-visual-companion-instructions.mdImplementation Plan
See:
docs/plans/2026-06-30-brainstorm-visualization.mdScope Manifest
1 | Add brainstorm visual companion guidance | Task 1, Task 2, Task 3 | issue-78-brainstorm-visualizationChanges
Behavior Proof
docs/plans/2026-06-30-brainstorm-visualization-behavior-proof.md.Test Plan
bash tests/brainstorm-visual-companion.sh→Results: 0 failure(s)bash tests/skill-content-grep.sh→ PASSbash tests/adk-path-canonicalization.sh→Results: 0 failure(s)bash tests/pipeline-evidence-doc-sync.sh→Results: 0 failure(s)bash tests/skill-cross-refs.sh→ PASSbash tests/hook-contracts.sh→All hook contract tests passed.bash tests/hook-stdout-discipline.sh→Results: 0 failure(s)bash tests/plan-scope-check-contracts.sh→Results: 0 failure(s)bash tests/version-check.sh→OK: All version files agree on version 6.6.1Review
Doc-reconciliation: clean
Deferred Work
docs/FOLLOWUPS.md.Generated by the implementing agent.