Skip to content

Add brainstorm visual companion guidance - #99

Merged
intel352 merged 16 commits into
mainfrom
issue-78-brainstorm-visualization
Jun 30, 2026
Merged

intel352 merged 16 commits into
mainfrom
issue-78-brainstorm-visualization

Conversation

@intel352

Copy link
Copy Markdown
Contributor

Summary

  • Adds a just-in-time Visual Companion workflow to skills/brainstorming/SKILL.md for mockups, Mermaid diagrams, architecture maps, and layout comparisons.
  • Adds a lazy-loaded skills/brainstorming/visual-companion.md guide with text fallback, accessibility, stale-visual, and no-secrets/PII rules.
  • Adds regression and behavior evidence for issue Brainstorm visualization #78, plus cross-host coverage docs and a follow-up for deferred browser/event-capture parity.

Closes #78.

Design

See: docs/plans/2026-06-30-brainstorm-visualization-design.md
ADR: decisions/0005-visual-companion-instructions.md

Implementation Plan

See: docs/plans/2026-06-30-brainstorm-visualization.md

Scope Manifest

  • PR Count: 1
  • Tasks: 3
  • Status: Complete 2026-06-30T10:37:25Z
  • PR row: 1 | Add brainstorm visual companion guidance | Task 1, Task 2, Task 3 | issue-78-brainstorm-visualization

Changes

  • Task 1: Added RED baseline, focused shell regression guard, visual guide, expected behavior fixture, coverage docs, and deferred browser parity follow-up.
  • Task 2: Added transcript-backed behavior proof covering conceptual text-only, just-in-time offer, decline, accept-with-visual-and-fallback, and stale visual handling.
  • Task 3: Ran targeted and full documented validation suites.

Behavior Proof

  • RED baseline: pre-change skill was missing explicit rules for visual offer, declined/no-reoffer behavior, accepted visual with fallback, and stale visual handling.
  • GREEN subject/reviewer: PASS for all five expected paths in docs/plans/2026-06-30-brainstorm-visualization-behavior-proof.md.

Test Plan

  • bash tests/brainstorm-visual-companion.sh → Results: 0 failure(s)
  • bash tests/skill-content-grep.sh → PASS
  • bash tests/adk-path-canonicalization.sh → Results: 0 failure(s)
  • bash tests/pipeline-evidence-doc-sync.sh → Results: 0 failure(s)
  • bash tests/skill-cross-refs.sh → PASS
  • bash tests/hook-contracts.sh → All hook contract tests passed.
  • bash tests/hook-stdout-discipline.sh → Results: 0 failure(s)
  • bash tests/plan-scope-check-contracts.sh → Results: 0 failure(s)
  • bash tests/version-check.sh → OK: All version files agree on version 6.6.1

Review

  • Adversarial design review: PASS
  • Adversarial plan review: PASS
  • Code review: SHIP-IT; minor cleanup suggestions applied before final validation.

Doc-reconciliation: clean

Deferred Work

  • Browser tab companion and click/event capture parity are intentionally deferred and tracked in docs/FOLLOWUPS.md.

Generated by the implementing agent.

Copilot AI review requested due to automatic review settings June 30, 2026 11:27
@intel352
intel352 merged commit fd4c682 into main Jun 30, 2026
9 checks passed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a host-neutral “Visual Companion” workflow to the brainstorming skill so agents can offer diagrams/mockups just-in-time (with text fallback and privacy rules), and backs it with fixtures, regression guards, and durable documentation/decision records.

Changes:

  • Extend skills/brainstorming/SKILL.md with Visual Companion offer/use/fallback/staleness rules and lazy-loaded guidance.
  • Add a bounded visual-companion.md guide plus expected-behavior fixture and a focused regression test.
  • Update coverage matrices, follow-ups, and planning/ADR artifacts to document scope (browser/event capture explicitly deferred) and evidence.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/cross-llm-coverage.md Updates brainstorming coverage notes to include visual companion guidance and deferrals.
tests/brainstorm-visual-companion.sh Adds regression guard asserting required Visual Companion markers/docs/fixtures and capability-row constraints.
skills/brainstorming/visual-companion.md Adds lazy-loaded guide with examples, accessibility/text fallback, and no-secrets/PII rules.
skills/brainstorming/test-fixtures/visual-companion/expected-behavior.md Adds fixture defining RED baseline + expected compliant paths (offer/decline/accept/stale).
skills/brainstorming/SKILL.md Introduces Visual Companion step + dedicated section and integrates into the process flow.
docs/plans/2026-06-30-brainstorm-visualization.md Implementation plan describing scope, tasks, tests, and proof protocol.
docs/plans/2026-06-30-brainstorm-visualization-plan-review.md Captures adversarial plan review and resolutions.
docs/plans/2026-06-30-brainstorm-visualization-design.md Design doc defining parity boundary, host capability matrix, and failure rules.
docs/plans/2026-06-30-brainstorm-visualization-design-review.md Captures adversarial design review and resolutions.
docs/plans/2026-06-30-brainstorm-visualization-behavior-proof.md Records RED baseline + GREEN subject/reviewer behavior proof and evidence.
docs/FOLLOWUPS.md Adds durable follow-up for deferred browser/click-event parity work.
docs/cross-llm-coverage.md Adds Visual Companion capability row and notes about best-effort rendering + deferrals.
decisions/0005-visual-companion-instructions.md ADR documenting decision, alternatives, and consequences.
AGENTS.md Documents the new focused test in the recommended validation suite.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

| Host declaration for skill conditionals | `Host: claude-code` in CLAUDE.md | `Host: codex` in `~/.codex/AGENTS.md` | `Host: opencode` in `~/.config/opencode/AGENTS.md` | n/a | Auto-detected as `hermes-agent` | `Host: zed-agent` in `~/.config/zed/AGENTS.md` or `%APPDATA%\\Zed\\AGENTS.md` |
| Skill discovery path (user scope) | `~/.claude/skills/` (personal skills); autodev installed to `~/.claude/plugins/marketplace/autodev/` via marketplace | `~/.agents/skills/` | `~/.config/opencode/skills/` | via plugin (no manual symlink) | `~/.hermes/skills/` (symlink or `hermes skills install`) | `~/.agents/skills/<skill-name>/` (flat; no namespace folder) |
| Model tier vocabulary | role names → `haiku`/`sonnet`/`opus` (see `agents/model-tiers.md`) | role names → `gpt-5.4-mini`/`gpt-5.4`/`gpt-5.5` | role names → host-pass-through | role names → host-pass-through | role names → host-pass-through | role names → host-pass-through |
| Visual companion output | ⚠️ markdown/Mermaid best-effort; browser deferred | ⚠️ markdown/Mermaid best-effort; browser deferred | ⚠️ markdown/Mermaid best-effort; browser deferred | ⚠️ markdown/Mermaid best-effort; browser deferred | ⚠️ markdown/Mermaid best-effort; browser deferred | ⚠️ markdown plus best-effort Mermaid rendering; browser deferred |
@intel352
intel352 deleted the issue-78-brainstorm-visualization branch June 30, 2026 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Brainstorm visualization

2 participants