Repository navigation
release: v6.5.10 (Planned-code compile-validity bug-class) - #95
Merged
Merged
Conversation
added 2 commits
June 29, 2026 15:31
…g-class 2x trend of embedded-Go compile bugs passing plan review as 'embedded code clean' on inspection: capability-assemble retro #1's range-over-slice P1 (`for t := range someSlice`) + scaffold-platform M1's `*Fragment != *Fragment` (FragmentSpec holds a []string → structs with slice fields aren't !=-comparable). The new plan-phase bug-class requires embedded code be compile-valid, not just plausible — covering range-over-slice + struct comparability. Source: docs/retros/2026-06-29-scaffold-platform-m1-retro.md (plugin follow-up).
Contributor
There was a problem hiding this comment.
Pull request overview
Release bump to v6.5.10, adding a new adversarial-design-review plan-phase bug-class focused on catching compile-invalid embedded code in plans while updating the Claude plugin manifest version to trigger the release automation.
Changes:
- Added Planned-code compile-validity to the plan-phase checklist in
skills/adversarial-design-review. - Bumped
.claude-plugin/plugin.jsonversion to 6.5.10 to drive release tagging/dispatch workflows.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| skills/adversarial-design-review/SKILL.md | Adds a new plan-phase bug-class row for validating embedded compiled code snippets. |
| .claude-plugin/plugin.json | Updates plugin manifest version to 6.5.10 for the release pipeline. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| | **Plugin-loader runtime layout** | Plans that spawn or load an external plugin process must build the binary in a layout the host's discovery code accepts. For wfctl: `$WFCTL_PLUGIN_DIR/<plugin-name>/<plugin-name>` + sibling `plugin.json`. Plans that `go build -o /tmp/single-binary` without the subdir + manifest sidecar will fail at runtime. | | ||
| | **Config-validation schema rules** | Plans that create new config files validated by a schema or CLI tool must satisfy that tool's invariants (e.g., for wfctl: `checkEntryPoints` requires ≥1 entry-point module like `http.server`/`scheduler.modular`/`messaging.broker`, OR a trigger/route/subscription/job/pipeline). Plans omitting required entry-point modules pass `bash -n` but fail schema validation at CI. | | ||
| | **Identifier / naming-convention match** | Config keys, flags, env vars, and command/code examples in the plan match the repo's established naming convention and the identifiers the code will actually use (grep the repo for the convention; a plan showing `snake_case` keys where the codebase uses `camelCase` = finding). **Distinct from `Config-validation schema rules`**, which checks tool-enforced schema invariants — this row checks human naming-convention consistency. Catches design-vs-code drift before code is written. | | ||
| | **Planned-code compile-validity** | When the plan **embeds Go (or other compiled) code** in prose/code-fences (struct definitions, helper functions, loop constructs), that code must be **compile-valid**, not just plausible. Two recurring slip classes: (a) **range-over-slice** written as `for t := range someSlice` (t is an int index, not the element) — must be `for _, t := range`; (b) **struct comparability** — structs containing slice/map/function fields (e.g. `FragmentSpec{ Fields []string }`) cannot be compared with `==`/`!=`; compare field-by-field. Eyeballing control flow is not enough; mentally (or actually) compile the embedded snippet. Flag any embedded code that would not compile. (2× trend: capability-assemble retro #1's range-over-slice P1 + scaffold-platform M1's `*Fragment != *Fragment` slip — both passed plan review as "embedded code clean" on inspection alone.) | |
| "name": "autodev", | ||
| "description": "Autonomous development workflow skills for coding agents: design, review, planning, execution, monitoring, and retrospectives", | ||
| "version": "6.5.9", | ||
| "version": "6.5.10", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump autodev → 6.5.10. Ships the new
Planned-code compile-validityadversarial-design-review bug-class (2x embedded-Go compile-slip trend: capability-assemble retro #1 P1 range-over-slice + scaffold-platform M1*Fragment != *Fragment). Merging this bumps.claude-plugin/plugin.json→ release-tag.yml auto-tags v6.5.10 + dispatches the marketplace (do NOT tag manually).