Repository navigation
fix(hooks): remove Claude-specific helper guidance - #92
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes Claude-specific environment variable guidance (CLAUDE_PLUGIN_ROOT) from scope-lock helper documentation and from the Stop-hook continuation messaging, and adds a regression test to ensure the completion guidance remains host-neutral.
Changes:
- Add a new hook contract test asserting
completion-claim-guardguidance does not mentionCLAUDE_PLUGIN_ROOTand still points toscope-lock-complete. - Update scope-lock and alignment-check skill documentation (and README workflow docs) to use host-neutral
bash hooks/<helper>instructions. - Update
completion-claim-guardto computehook_dironce and use it to print a resolved path to the siblingscope-lock-completehelper.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/hook-contracts.sh | Adds a regression test ensuring completion helper guidance is host-neutral. |
| skills/scope-lock/SKILL.md | Replaces Claude-specific helper invocation guidance with host-neutral bash hooks/... commands. |
| skills/alignment-check/SKILL.md | Simplifies scope-lock helper instructions to avoid host-specific env var guidance. |
| README.md | Updates scope-lock workflow documentation to use host-neutral helper invocation. |
| hooks/pre-tool-scope-guard | Updates .scope-lock write-block guidance to remove CLAUDE_PLUGIN_ROOT references. |
| hooks/completion-claim-guard | Uses a resolved hooks directory to reference scope-lock-complete instead of CLAUDE_PLUGIN_ROOT. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
160
to
162
| Only stop if one of these is true: | ||
| - The entire locked design is complete and verified; run bash \"\${CLAUDE_PLUGIN_ROOT:-.}/hooks/scope-lock-complete\" <plan> --evidence \"<verification>\" to mark it complete and remove lock traces. | ||
| - The entire locked design is complete and verified; run bash \"${hook_dir}/scope-lock-complete\" <plan> --evidence \"<verification>\" to mark it complete and remove lock traces. | ||
| - There is a hard blocker that requires human input. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
completion-claim-guardprint the resolved siblingscope-lock-completehelper path instead ofCLAUDE_PLUGIN_ROOTguidance.bash hooks/<helper>instructions from the autodev checkout/plugin root.CLAUDE_PLUGIN_ROOT.TDD proof
With fix reverted:
With fix restored:
Verification