fix: ignore duplicate topo traversal tips - #2903
Merged
Merged
Conversation
Sebastian Thiel (Byron)
force-pushed
the
traverse-dupl-tip
branch
from
August 11, 2026 14:52
a8c817e to
3819446
Compare
Sebastian Thiel (Byron)
marked this pull request as ready for review
August 11, 2026 14:53
Sebastian Thiel (Byron)
enabled auto-merge
August 11, 2026 14:53
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3819446a56
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
Sebastian Thiel (Byron)
disabled auto-merge
August 11, 2026 15:02
<!-- agent --> Repeated starting commits were inserted into the topological queue more than once, which could duplicate the tip and truncate walks depending on sorting. The regression compares one tip with the same tip supplied twice for both topological and date ordering, with and without a commit graph. Ignore repeated tips at the builder boundary while preserving their first-seen order. This matches Git's duplicated-head behavior covered by t/t6003-rev-list-topo-order.sh. Assisted-by: GPT 5.6 Co-authored-by: GPT 5.6 <codex@openai.com>
<!-- agent --> Replacing a continued value that ended at a comment on the next physical line removed the continuation newline, turning the standalone comment into an inline comment on the replacement value. Retain the final continuation newline when an empty ValueDone event is followed by a comment. Cover hash and semicolon comments with LF and CRLF, along with quoted comment markers that remain value content. This matches git config parsing behavior. Assisted-by: GPT 5.6 Co-authored-by: GPT 5.6 <codex@openai.com>
Sebastian Thiel (Byron)
force-pushed
the
traverse-dupl-tip
branch
from
August 11, 2026 15:07
3819446 to
f398668
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tasks
This section is for Byron only. Models continuing this PR must not add, remove, check, uncheck, rename, or reorder checkboxes here.
Everything below this line was generated by
Codex GPT-5.Created by Codex on behalf of Byron. Byron will review before this is ready to merge.
Fixes #2902
Summary
Git baseline:
t/t6003-rev-list-topo-order.shverifies that duplicated head arguments produce the same complete walk.Validation
cargo test -p gix-traversecargo fmt --all -- --checkgit diff --check