change!: make checkout() optionally consider the previous index - #2900
change!: make checkout() optionally consider the previous index#2900Dirkjan Ochtman (djc) wants to merge 1 commit into
Conversation
777163c to
fcc652d
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 777163c7c1
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "Codex (@codex) address that feedback".
|
I spent 10m with it and arrived at the conclusion that this won't help me delivering the required quality level. So it's best to close it and wait for me to get to it, which will be in the coming months. Analysis
Codex created, not my speech. • Found four behavioral differences from Git:
|
We've noticed some issues with how
checkout()works differently fromgit checkoutin gitoxide, since it does not remove files that become untracked when checking out into an existing working dir:This PR adds a
previous_index: Option<&gix_index::State>argument to make it more obvious that this is a thing that people need to think about, and makes it easier to get CLI-like behavior.(With help from Claude.)