Skip to content

Use GIX_TEST_FIXTURE_HASH for more tests - #2898

Merged
Sebastian Thiel (Byron) merged 2 commits into
GitoxideLabs:mainfrom
cruessler:run-more-tests-with-sha-256-2
Aug 9, 2026
Merged

Use GIX_TEST_FIXTURE_HASH for more tests#2898
Sebastian Thiel (Byron) merged 2 commits into
GitoxideLabs:mainfrom
cruessler:run-more-tests-with-sha-256-2

Conversation

@cruessler

Copy link
Copy Markdown
Contributor

This PR adds explicit test runs under GIX_TEST_FIXTURE_HASH=sha1 and GIX_TEST_FIXTURE_HASH=sha256 for the following crates:

  • gix-dir
  • gix-fsck
  • gix-negotiate

This PR follows the example from this commit and earlier ones: 4a0ca97 (merged in #2893).

This is part of a series of PRs where I try to find crates that pass their tests under GIX_TEST_FIXTURE_HASH=sha1, but not yet under GIX_TEST_FIXTURE_HASH=sha256.

@cruessler
Christoph Rüßler (cruessler) marked this pull request as ready for review August 9, 2026 09:03
Following the example from these commits and earlier ones:

- bbea2c4
- 4a0ca97

This commit adds test runs under `GIX_TEST_FIXTURE_HASH=sha1` and
`GIX_TEST_FIXTURE_HASH=sha256` for the following crates:

- `gix-dir`
- `gix-fsck`
- `gix-negotiate`
- recreate archives
@Byron
Sebastian Thiel (Byron) force-pushed the run-more-tests-with-sha-256-2 branch from 590e045 to 351d793 Compare August 9, 2026 18:12
@Byron

Copy link
Copy Markdown
Member

Thanks a lot!

When looking at the justfile (whose edits were following the usual pattern) I kept thinking that the cargo nextest run --no-fail-fast probably already runs a bunch of SHA-256 tests due to the way it compiles everything at once, with all features. But then again, if it would have, it would have failed. In any case, I thought it would at least run the SHA-1 tests. From there I wonder if the separate SHA-1 invocations of the individual crates are still needed.
Maybe something to investigate the next time the file is edited.

@Byron
Sebastian Thiel (Byron) merged commit 7241150 into GitoxideLabs:main Aug 9, 2026
32 checks passed
@cruessler

Copy link
Copy Markdown
Contributor Author

I was wondering the same. I added the GIX_TEXT_FIXTURE_HASH=sha1 lines mostly for consistency. I’m going to double-check whether some of them can be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants