Refactor Command Generation Pipeline and Improve Testing Suite - #89
Merged
Conversation
- Implement modular command generators in `pymkv/command_generators/` to replace monolithic logic in MKVFile. - Add progress tracking support to `MKVFile.mux()` with callback integration. - Refactor unit tests into granular files under `tests/command_generators/` using shared mocks in `conftest.py`. - Update `MKVTrack` attributes to remove legacy `flag_` prefixes for cleaner API usage. - Standardize docstrings in `models.py` to match project style. - Optimize import structure to resolve circular dependency risks.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #89 +/- ##
===========================================
+ Coverage 67.25% 82.95% +15.69%
===========================================
Files 10 20 +10
Lines 959 1091 +132
===========================================
+ Hits 645 905 +260
+ Misses 314 186 -128 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…tion, resolving namespace collision between the class and module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a major refactor to the pymkv library, transitioning from a monolithic command generation approach to a modular, class-based pipeline. It also enhances the testing infrastructure and adds new functionality for progress tracking.