Skip to content

Feat/extract attachments - #88

Closed
alucryd wants to merge 2 commits into
GitBib:masterfrom
alucryd:feat/extract-attachments
Closed

Feat/extract attachments#88
alucryd wants to merge 2 commits into
GitBib:masterfrom
alucryd:feat/extract-attachments

Conversation

@alucryd

@alucryd alucryd commented Dec 16, 2025

Copy link
Copy Markdown

Adds the ability to extract existing attachments

@codecov

codecov Bot commented Dec 16, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 41.46341% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.03%. Comparing base (5c10717) to head (1287e95).
⚠️ Report is 50 commits behind head on master.

Files with missing lines Patch % Lines
pymkv/MKVAttachment.py 51.61% 15 Missing ⚠️
pymkv/MKVFile.py 10.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
- Coverage   67.25%   66.03%   -1.23%     
==========================================
  Files          10       10              
  Lines         959      995      +36     
==========================================
+ Hits          645      657      +12     
- Misses        314      338      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GitBib

GitBib commented Dec 16, 2025

Copy link
Copy Markdown
Owner

Thank you for your contribution to the repository.
It would be good to add tests for the new functionality so we can be sure that the functions work correctly and will remain stable in the future.

@GitBib GitBib closed this Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants