Skip to content

Add support for SRT subtitles with tests and CLI updates - #34

Merged
GitBib merged 3 commits into
masterfrom
srt_to_srt
Nov 9, 2025
Merged

Add support for SRT subtitles with tests and CLI updates#34
GitBib merged 3 commits into
masterfrom
srt_to_srt

Conversation

@GitBib

@GitBib GitBib commented Nov 9, 2025

Copy link
Copy Markdown
Owner

Description

This pull request introduces SRT subtitle format support to the project. Key changes include:

  • Implemented SRT format detection and conversion in the Subtitle class.
  • Added extensive test coverage for SRT parsing, export functionality, and edge cases.
  • Enhanced the CLI to process SRT files for export and dialogue extraction.
  • Refactored the test suite to replace os with pathlib for improved file handling.
  • Updated test fixtures by adding a sample SRT file for testing.

- Implemented SRT format detection and conversion within `Subtitle` class.
- Added comprehensive tests for SRT parsing, edge cases, and export functionality.
- Improved CLI to handle SRT files for export and dialogue extraction.
- Refactored test suite: replaced `os` with `pathlib` for file handling in test cases.
- Updated test fixtures to include a sample SRT file.
@codecov

codecov Bot commented Nov 9, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.38%. Comparing base (d704a4d) to head (af29cf1).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
+ Coverage   99.27%   99.38%   +0.11%     
==========================================
  Files           5        5              
  Lines         138      163      +25     
==========================================
+ Hits          137      162      +25     
  Misses          1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GitBib
GitBib merged commit e441131 into master Nov 9, 2025
48 checks passed
@GitBib
GitBib deleted the srt_to_srt branch November 9, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant