General enhancements - #181
Open
ProjectDislocate wants to merge 80 commits into
Open
Conversation
- Add error check when finding chapter list - Normalize URLs with proper trimming and validation - Add fallback for missing select box - Add empty chapters validation - Fix variable naming (issueUrl -> issueURL)
- Add detailed debug logging with base64-encoded snippets - Log fetch URL and request failures - Show obfuscated entry count and decoded link preview - Limit snippet size to prevent log overflow
thx hollisticated-horse
fixes issues with certain images not being decoded properly
causes issues on windows file systems
go-libjpeg doesn't support encoding as many formats as std go lib
Series titles are now used to set the folder the comics are placed in. Chapter titles are used to set the filename. This change also lets site providers fill in more metadata about a comic before any folder is created. More advanced formatting folder structures are enabled by this, like futher subdividing comics into volume folders.
prevents long running downloads from failing despite more images in queue
Collaborator
|
Hey, thank you for the PR ! I was about to merge my own changes, so you can remove them from this PR. I'll read through this in the next week. I hope I can merge this quickly :D |
Collaborator
|
@ProjectDislocate actually, looking at my own changes, I think there might be a bit of an overlap in features. I also changed quite a few things around. I would love to have you input before merging my own PR → #182 |
Author
|
I'll rebase my changes on top of your changes once you merge it in if your okay with that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry for the massive pr, this rapidly spiraled as I found more and more issues. (I understand if this is too much, figured I should at least attempt to upstream this instead of having it rot in a private fork.)
This pr includes: