Issue 230: Directory rename deletes children whose row keys are unchanged - #231
Open
milandesai wants to merge 1 commit into
Open
Issue 230: Directory rename deletes children whose row keys are unchanged#231milandesai wants to merge 1 commit into
milandesai wants to merge 1 commit into
Conversation
pjeli
reviewed
Nov 21, 2016
| else | ||
| dirsToDelete.add(INodeDirectory.valueOf(input)); | ||
| public void apply(INode child) throws IOException { | ||
| if (!child.getRenameState().getFlag()) { |
Contributor
There was a problem hiding this comment.
Could we have filtered somewhere else rather than here? I think it may make more sense to have this method stay the same but to filter out potential directories that shouldn't be deleted in the actual rename method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to #230