docs: draft-PR merge safety + npm 0.8.0 roadmap note#1250
Merged
Conversation
WHAT: Add an explicit rule to the gh bundled skill's Pull Requests section — a draft PR is a 'do NOT merge yet' signal; never merge it and never mark it ready (gh pr ready) unless a human names that PR by number. A blanket 'merge on green' / 'merge my PRs' instruction must skip drafts and say so, never promote them. Includes the isDraft check commands. WHY: A 'merge on green' sweep nearly promoted a deliberately-drafted PR (#1222, held for a release gate). Draft is the mechanism authors use to keep exactly that from happening; the skill must encode that drafts are untouchable so the accident can't recur. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
held in draft) WHAT: Record the npm installer (@gilamonster shim, PR #1222) as roadmap Step 11.4 with an explicit release decision: the first npm publish ships with 0.8.0, not before. Note that PR #1222 is kept in draft AS the hold mechanism and links it so the intent survives even if branch feat/npm-shim is closed/deleted by accident. WHY: The 'hold npm until 0.8.0' intent was not written down anywhere — it lived only as the draft state of a PR, which evaporates if the branch is closed. The roadmap is the durable home for a release-gating decision. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
hartsock
added
the
risk:low
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Two small docs/governance changes prompted by a near-miss where a 'merge on green' sweep almost promoted a deliberately-drafted PR (#1222):
gh pr ready-ing a draft; the sweep must skip drafts and say so. Includes theisDraftcheck.feat/npm-shimis closed/deleted by accident.Test plan
Out of scope
🤖 Generated with Claude Code