Replace instanceof check with Promise.resolve() in toast.promise - #13
Open
giraugh wants to merge 1 commit into
Open
Replace instanceof check with Promise.resolve() in toast.promise#13giraugh wants to merge 1 commit into
instanceof check with Promise.resolve() in toast.promise#13giraugh wants to merge 1 commit into
Conversation
Owner
|
Oooh very nice. |
giraugh
force-pushed
the
feat/loosen-promise-check
branch
from
November 12, 2025 04:23
97951d7 to
6604ecc
Compare
Author
|
Hello! Sorry for the months long delay, I've finally remove that lock file 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Really enjoying using this library but have been experiencing a minor point of friction when using
toast.promise(). The problem being that theinstanceof Promisecheck fails for promise-like objects that are not strictly using thePromiseclass. This PR just swaps the promise check for a Promise.resolve() call which ensures that the value conforms to the promise interface.But no stress at all if this is not the direction you want to take this method 👍
Cheers!