fix: LED override, Material Station on the Creator 5 series, camera switch (v1.3.2) - #20
Merged
Merged
Conversation
Co-authored-by: RedAces <redaces@gmx.de> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012ig1q3oNdhzkBtzbATQMWi
Co-authored-by: RedAces <redaces@gmx.de> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012ig1q3oNdhzkBtzbATQMWi
Co-authored-by: RedAces <redaces@gmx.de> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012ig1q3oNdhzkBtzbATQMWi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ships 1.3.2. Requires
flashforge-python-api>=1.3.2(published).Fixes
led_control_overrideusing its unset valueFalse. That parameter is tri-state —Nonemeans "no override",Trueforces the capability on,Falseforces it off — so with the option off (the default) the integration vetoed the printer's own correct capability report on every model. It now sendsNonewhen off. Diagnosed on a Creator 5 Pro, where/productreportedlightCtrlState: 1all along.has_matl_station, a raw/detailpassthrough the Creator 5 never sends. Fixed upstream in the library (1.3.2), which derives the capability from the slot data; the manifest floor moves accordingly.Changed
streamCtrl_cmdreturns success and does nothing there, andcameraStreamUrlstays populated so the switch snapped back toonon the next poll. Inert and un-toggleable, so it is now omitted entirely rather than shipped as a dead control. Thecameraentity is unaffected. Refs Camera switch permanently unavailable on Creator 5 Pro (availability gated on is_pro instead of is_creator5_pro) #17.Notes