feat: consume shared sf-validate/sf-deploy reusable workflows - #5
Merged
Conversation
…lows - pr-validate.yml -> sf-validate.yml@v1: delta check-only deploy with tests against the Dev Hub (quick-deploy handoff), Code Analyzer on changed files, scratch-org validation, sticky PR comment, audit artifact - deploy.yml -> sf-deploy.yml@v1: production GitHub Environment gate, quick deploy of the PR-validated request (delta/full fallbacks), GitHub Deployment record, audit artifact; workflow_dispatch full-deploy bootstrap - delete validate-pr.yml / deploy-staging.yml / deploy-production.yml; STAGING_AUTH_URL and PRODUCTION_AUTH_URL secrets are obsolete - docs/CICD.md: setup, mermaid pipeline diagram, quick-deploy mechanics, audit trail + 90-day retention caveat (S3 export as enterprise path) - align README, CONTRIBUTING and deployment-devops reference with the trunk-based, single-gate model Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ker Hub Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replaces the three inline CI/CD workflows with thin callers (~25 lines each) of the reusable Salesforce CI/CD layer in shared-github-actions:
pr-validate.ymlsf-validate.yml@v1sf-validate-<run>audit artifactdeploy.ymlsf-deploy.yml@v1productionenvironment gate (required reviewer), quick deploy of the PR-validated request (delta/full fallbacks), GitHub Deployment record,sf-deploy-production-<run>audit artifactvalidate-pr.yml,deploy-staging.yml,deploy-production.yml—STAGING_AUTH_URL/PRODUCTION_AUTH_URLsecrets are obsolete;DEVHUB_AUTH_URLis the only secret.template-verify.ymluntouched.docs/CICD.md: setup, mermaid pipeline diagram, quick-deploy mechanics, audit trail + 90-day retention caveat (S3 export noted as the enterprise upgrade path)..claude/references/deployment-devops.mdaligned with the trunk-based single-gate model.Sequencing
PR Validatecheck here stays red until shared-github-actions#6 merges andv1.2.0is tagged (the@v1tag doesn't containsf-validate.ymlyet). After tagging, re-run the failed check — this PR run is the first end-to-end signal (docs/workflows-only delta → graceful no-changes skip + analyzer + scratch org + PR comment).After merge
productiongate on the resulting deploy run (empty delta → skip).gh workflow run deploy.yml -f full-deploy=true→ approve gate.🤖 Generated with Claude Code