refactor: call shared docker-build-test-push reusable workflow - #8
Merged
Conversation
Test Results - sf-bulk19 tests 19 ✅ 15s ⏱️ Results for commit f6a04ab. ♻️ This comment has been updated with latest results. |
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Test Results - sf-ci15 tests 15 ✅ 14s ⏱️ Results for commit f6a04ab. ♻️ This comment has been updated with latest results. |
Test Results - sf-devcontainer22 tests 22 ✅ 14s ⏱️ Results for commit f6a04ab. ♻️ This comment has been updated with latest results. |
build-and-push.yml is now a thin caller: a matrix fans out over the three images, each invoking the shared reusable workflow (build → test → push, incl. keyless cosign signing and the two-tag scheme). The repo-specific release job stays local and now aggregates the per-image version-report artifacts into the release notes. Temporarily references the shared feature branch; flipped to @v1 before merge. Implements docs/reusable-workflow-migration-design.md. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- CLAUDE.md + .claude/references/github-actions.md rewritten for the thin caller + shared reusable workflow, @v1 pin, and cosign signing - Root README: two-row supported-tags table, cosign verification command in Security & provenance, release flow description updated - Per-image READMEs: rolling-tag references replaced with latest/exact version, 'Verify the signature' sections added - CHANGELOG: reusable-workflow migration, cosign signing, version tables in release notes, tag-scheme change Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
gambe94
force-pushed
the
feat/reusable-docker-workflow
branch
from
July 12, 2026 12:45
aa9e577 to
4dc7196
Compare
shared-github-actions v1.1.0 is released; @v1 is its floating major tag (moved by the shared repo's release process). Chosen over @main (unreleased, may break) and over a SHA pin (no automation watching cross-repo workflow refs here) — see the shared repo's Versioning docs. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements
docs/reusable-workflow-migration-design.md:build-and-push.ymlbecomes a thin caller — a matrix over the 3 images invokesshared-github-actions/docker-build-test-push.yml(build → test → multi-arch push with SBOM/provenance + keyless cosign signing), while the repo-specificreleasejob stays local and now appends per-image tool-version tables (Node/npm/SF CLI/plugins, read from the built images) to the CHANGELOG-based release notes.Behavior changes (deliberate, per approved design):
X.Y.Z+latestonly — rolling:1/:1.2tags droppedRollout (design doc §7)
v1.1.0there@v1in this PR, re-verify, merge🤖 Generated with Claude Code