Fix: migrate off sf-jwt-login, which no longer exists upstream - #7
Open
gambe94 wants to merge 1 commit into
Open
Fix: migrate off sf-jwt-login, which no longer exists upstream#7gambe94 wants to merge 1 commit into
gambe94 wants to merge 1 commit into
Conversation
shared-github-actions merged sf-jwt-login into sf-org-login behind an `auth-method` input and released the result as v2. This workflow called sf-jwt-login@main, so it broke the moment that merge landed on main — the action directory is simply gone. Switched to sf-org-login with `auth-method: jwt`. The other inputs are unchanged and all six are declared on sf-org-login@v2; the job already grants the `id-token: write` + `contents: read` the JWT path needs. Pinned @v2 rather than @main. Tracking a moving default branch is what turned an upstream refactor into a broken workflow here, and the upstream README calls out @main as development-only. Note the merged action defaults differ from the old one — org-alias `target` not `devhub`, set-default-dev-hub false not true. Both were already explicit here, so behaviour is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This workflow is broken on
mainright now.shared-github-actionsmergedsf-jwt-loginintosf-org-loginbehind anauth-methodinput and released it as v2. This workflow calledsf-jwt-login@main, so it broke the moment that merge landed — the action directory no longer exists. Nothing has failed visibly yet only because this is aworkflow_dispatchworkflow, so it does not run until someone triggers it.The change
Verification
sf-org-login@v2id-token: write+contents: read, which is what the JWT path requiresactionlint1.7.12 cleanWhy
@v2and not@mainTracking a moving default branch is precisely what turned an upstream refactor into a broken workflow here. Upstream documents
@mainas development-only.Behaviour note
The merged action has different defaults from the old one —
org-aliasistargetrather thandevhub, andset-default-dev-hubisfalserather thantrue. Both were already set explicitly here, so behaviour is unchanged.