chore(samples): uiscene delegate - #1292
Conversation
Migrate the dogfooding app and the package example apps to the UIScene lifecycle (https://docs.flutter.dev/release/breaking-changes/uiscenedelegate): - Register plugins from `didInitializeImplicitFlutterEngine` via `FlutterImplicitEngineDelegate` instead of `didFinishLaunchingWithOptions` - Add `UIApplicationSceneManifest` with `FlutterSceneDelegate` to each Info.plist - Bump `app_links` to ^7.2.1 for scene-based deep link handling Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (10)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe iOS Runner applications now use Flutter implicit engine initialization for plugin registration and method-channel setup, declare single-scene Flutter configurations, remove dogfooding CocoaPods resource copying, and update the ChangesiOS Flutter lifecycle migration
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant AppDelegate
participant FlutterImplicitEngineBridge
participant GeneratedPluginRegistrant
participant FlutterMethodChannel
AppDelegate->>FlutterImplicitEngineBridge: initialize implicit Flutter engine
FlutterImplicitEngineBridge->>GeneratedPluginRegistrant: register plugins with pluginRegistry
FlutterImplicitEngineBridge->>FlutterMethodChannel: create channel with registrar messenger
FlutterMethodChannel->>AppDelegate: forward method calls
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1292 +/- ##
=======================================
Coverage 11.20% 11.20%
=======================================
Files 686 686
Lines 50350 50350
=======================================
Hits 5640 5640
Misses 44710 44710 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🎯 Goal
UISceneDelegate migration needs to happen before iOS 27 and xcode 27 are stable.
🛠 Implementation details
This is sample app only
https://docs.flutter.dev/release/breaking-changes/uiscenedelegate
It also updates app_links dependency with support for UISceneDelegate
Summary by CodeRabbit
Bug Fixes
Updates