Repository navigation
chore(demo): add channel preview overlay - #3157
Merged
Merged
Conversation
Contributor
|
Size Change: 0 B Total Size: 672 kB ℹ️ View Unchanged
|
MartinCupela
changed the title
oliverlaz
approved these changes
Apr 30, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3157 +/- ##
=======================================
Coverage 83.58% 83.58%
=======================================
Files 434 434
Lines 12926 12926
Branches 4159 4159
=======================================
Hits 10804 10804
Misses 2122 2122 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MartinCupela
changed the title
|
🎉 This PR is included in version 14.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Replace the join / leave channel button in the ChannelHeader with join overlay over channels which the user is not member of. This will return back the option to expand the sidebar, when collapsed as that button was replaced with join / leave channel in the ChannelHeader.
Observed server issues:
WS events related to acquiring channel membership are not delivered reliably - many times not delivered and thus the UI is not updated (from non-member -> to member).
🎨 UI Changes
If a user does not have permission to join the channel, we change the copy and hide the join button (even though it could be frustrating to receive channels, that a user cannot join):