DO NOT MERGE - just for code review purposes :)#4
Open
julienisbet wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @GeoSauer - this generally looks really good. My main piece of feedback is in how you are setting up users -- when you create users, I would suggest allowing the user to also send up the additional info you need (class, level etc.) so that you don't need to make an additional update call to add that information in after the fact. This will simplify your tests as well because you won't need the additional API call in your tests.
Let me know if anything doesn't make sense -- overall looks really good. Looking forward to seeing the app!