fix(connector): preserve suffix stores on gpu prefix hits#93
Merged
Conversation
- Plan missing prefix suffix stores before returning zero external tokens - Cover GPU-local hits that fully shadow shorter DaseR hits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
When vLLM already has a longer GPU-local prefix than DaseR, the DaseR hit contributes no external tokens. The scheduler returned before preparing the missing suffix store, leaving the lower-tier prefix permanently shorter until GPU eviction forced recomputation.
Test plan
PYTHONHASHSEED=0 pytest -q -m "not integration" --ignore=tests/integration --ignore=tests/connector/test_daser_connector.py --ignore=tests/connector/test_gds_transfer.py tests/passes: 353 passedpre-commit run --all-filespassesChecklist
pre-commit run --all-filespasses