chore(connector): remove stale load and benchmark helpers#89
Merged
Conversation
- Delete the old batch load pipeline now superseded by request-level dispatching. - Remove dead benchmark correctness helpers and unused staging/scheduler/server helpers. - Drop tests that only exercised removed compatibility paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What does this PR do? (1-3 bullet points)
Motivation
This cleanup reduces the connector surface area after the prefix load staging pipeline moved to the request-level dispatcher. Keeping both the old batch pipeline and the active dispatcher path made the load code harder to reason about and preserved test-only production helpers.
Test plan
How was this tested?
PYTHONHASHSEED=0 pytest -q -m "not integration" --ignore=tests/integration --ignore=tests/connector/test_daser_connector.py --ignore=tests/connector/test_gds_transfer.py tests/passespre-commit run --all-filespassesValidation performed:
ruff check daser tests benchmarkspython3 -m compileall -qon changed Python filespython -m pytest -q tests/unit/test_benchmark_correctness.pygit diff --checkvulture --min-confidence 60audit; remaining findings inspected as dynamic/framework/protocol false positivesN/A / not run:
torch/vllmare unavailable.pre-commit run --all-fileswas not run; the commit hook ran formatting on staged files.Checklist
pre-commit run --all-filespasses