Skip to content

chore(monitoring): shorten grafana query windows#81

Merged
GentleCold merged 1 commit into
masterfrom
chore/monitoring-short-grafana-ranges
Jun 13, 2026
Merged

chore(monitoring): shorten grafana query windows#81
GentleCold merged 1 commit into
masterfrom
chore/monitoring-short-grafana-ranges

Conversation

@GentleCold

@GentleCold GentleCold commented Jun 13, 2026

Copy link
Copy Markdown
Owner

Summary

  • Reduce Grafana dashboard query windows for benchmark-facing DaseR panels from long windows to 30 seconds.
  • Update the monitoring documentation examples to match the shorter dashboard windows.
  • Remove brittle Grafana dashboard JSON assertions from CPU unit tests instead of maintaining Grafana-specific unit test expectations.

Validation

  • /data/zwt/vllm/bin/python -m pytest -q tests/unit/test_benchmark_unified_utils.py
  • /data/zwt/vllm/bin/python -m pytest -q -m "not integration" --ignore=tests/integration --ignore=tests/connector/test_daser_connector.py --ignore=tests/connector/test_gds_transfer.py tests/
  • /data/zwt/vllm/bin/python -m ruff check tests/unit/test_benchmark_unified_utils.py
  • /data/zwt/vllm/bin/python -m ruff format --check tests/unit/test_benchmark_unified_utils.py
  • python -m json.tool deploy/monitoring/grafana/dashboards/daser-overview.json
  • rg "\[5m\]|\[1m\]|\[2m:1s\]" deploy/monitoring/grafana/dashboards/daser-overview.json returned no matches
  • git diff --check

Impact

  • Grafana panels should react faster during short benchmark runs, making transfer throughput and latency phase boundaries easier to inspect.
  • The Python unit suite no longer locks down Grafana JSON details that are better validated manually or through Grafana provisioning checks.

- Reduce Grafana dashboard query windows for benchmark-facing panels to 30 seconds.
- Keep monitoring documentation examples aligned with the shorter dashboard windows.
- Remove brittle Grafana dashboard JSON assertions from CPU unit tests.
@GentleCold
GentleCold force-pushed the chore/monitoring-short-grafana-ranges branch from 8472c6d to 72df8fa Compare June 13, 2026 09:24
@GentleCold
GentleCold marked this pull request as ready for review June 13, 2026 09:28
@GentleCold
GentleCold merged commit cae777f into master Jun 13, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant