chore(monitoring): shorten grafana query windows#81
Merged
Conversation
- Reduce Grafana dashboard query windows for benchmark-facing panels to 30 seconds. - Keep monitoring documentation examples aligned with the shorter dashboard windows. - Remove brittle Grafana dashboard JSON assertions from CPU unit tests.
GentleCold
force-pushed
the
chore/monitoring-short-grafana-ranges
branch
from
June 13, 2026 09:24
8472c6d to
72df8fa
Compare
GentleCold
marked this pull request as ready for review
June 13, 2026 09:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
/data/zwt/vllm/bin/python -m pytest -q tests/unit/test_benchmark_unified_utils.py/data/zwt/vllm/bin/python -m pytest -q -m "not integration" --ignore=tests/integration --ignore=tests/connector/test_daser_connector.py --ignore=tests/connector/test_gds_transfer.py tests//data/zwt/vllm/bin/python -m ruff check tests/unit/test_benchmark_unified_utils.py/data/zwt/vllm/bin/python -m ruff format --check tests/unit/test_benchmark_unified_utils.pypython -m json.tool deploy/monitoring/grafana/dashboards/daser-overview.jsonrg "\[5m\]|\[1m\]|\[2m:1s\]" deploy/monitoring/grafana/dashboards/daser-overview.jsonreturned no matchesgit diff --checkImpact