Conversation
Add a couple of shell scripts that allow for running the FDP Schema Update Tool with custom CA trust.
hcvdwerf
left a comment
There was a problem hiding this comment.
I have a question about this
If the FDP is publicly exposed and uses a certificate issued by a publicly trusted CA (e.g., Let’s Encrypt, DigiCert, GlobalSign), the default JVM truststore should already validate the TLS chain correctly. In that scenario, introducing a custom truststore does not improve security but does introduce additional operational complexity:
- Extra scripts and maintenance burden
- Volume mounts and JVM configuration flags
- Additional failure modes (PKIX issues, mismatches, etc.)
|
@hcvdwerf, I agree with you that it adds operational complexity. The use case for this is if the FDP endpoint is not publicly available. For example, at our node we have two instances of the GDI FDP, at the moment. Development and Staging environment. We have no plans for exposing the dev environment, not even to the rest of the GDI network. It is just for internal testing. When it is just internal there is no point using publicly trusted CA. As I mentioned during one of the WP4 meetings, we do have our reservations about exposing publicly the FDP and the AF Beacon for the moment. We were actually planning to expose only the internal proxy to the GDI portal and the Beacon Network.
Furthermore, when working internally, for example applying changes with the schema tool, we are doing this directly through internal clients. |
| @@ -0,0 +1,28 @@ | |||
| #!/bin/sh | |||
There was a problem hiding this comment.
Could you add license information in the top?
for example
#!/usr/bin/env bash
SPDX-FileCopyrightText: Stichting Health-RI
SPDX-License-Identifier: AGPL-3.0-only
| @@ -0,0 +1,29 @@ | |||
| #!/bin/sh | |||
There was a problem hiding this comment.
@hcvdwerf I've added SPDX field but honestly I might have done it wrong. Who should be the copyright owner. Is it the individual country nodes or is it the 1PLUSMG initiative (I do not thing we have a legal entity yet).
hcvdwerf
left a comment
There was a problem hiding this comment.
Please resolve comments
…metadata into custom_ca
Reference the Health-RI as we are expanding their work.

🚀 Pull Request Checklist
Title: Custom CA Shell scripts
Description:
Add a couple of shell scripts that allow the FDP Schema Update Tool to be executed against an endpoint served with a Custom CA Certificate.
Context: Some FDP endpoints might be served with custom Certificate Authorities. This allows for flexible addition of trusted Root certificates at runtime without rebuilding the docker image.
Changes:
Testing:
Screenshots (if applicable):
Additional Information:
Checklist: