Skip to content

feat: Added text announcement for closing CR registrations - #57

Merged
Akshat-Raj merged 3 commits into
Genesis-ISE-DSCE:mainfrom
Akshat-Raj:cr
Apr 14, 2026
Merged

feat: Added text announcement for closing CR registrations#57
Akshat-Raj merged 3 commits into
Genesis-ISE-DSCE:mainfrom
Akshat-Raj:cr

Conversation

@Akshat-Raj

Copy link
Copy Markdown
Collaborator

Added text announcement for closing CR registrations, and in api/register/route.ts commented CR from EVENT_NAMES.

Copilot AI review requested due to automatic review settings April 14, 2026 18:09
@vercel

vercel Bot commented Apr 14, 2026

Copy link
Copy Markdown

@Akshat-Raj is attempting to deploy a commit to the Genesis' projects Team on Vercel.

A member of the Team first needs to authorize it.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a homepage announcement indicating Clash Royale registrations are closed, and updates the registration API’s event-name mapping accordingly.

Changes:

  • Adds a prominent Hero-section text announcement stating Clash Royale registrations are closed (and on-spot registrations are available).
  • Comments out clash_royale from the EVENT_NAMES mapping used for registration emails in api/register.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/components/sections/Hero.tsx Adds a new announcement paragraph in the Hero section about Clash Royale registration closure.
src/app/api/register/route.ts Comments out the clash_royale readable name entry in EVENT_NAMES.
Comments suppressed due to low confidence (1)

src/app/api/register/route.ts:17

  • Commenting out clash_royale here only removes the human-readable label for emails (it will fall back to the raw event string), but it does not actually prevent Clash Royale registrations. Since Participant's schema enum still allows clash_royale, clients can still POST { event: "clash_royale" } directly to this endpoint and successfully register. If registrations are meant to be closed, add an explicit validation/deny-list check in this route (e.g., return 403/400 for clash_royale) and/or remove clash_royale from the allowed event IDs / Participant enum so the backend enforces the closure.
const EVENT_NAMES: Record<string, string> = {
  pitch_perfect: "Ideathon",
  typemaster: "Typemaster",
  // clash_royale: "Clash Royale",
  coding_relay: "Coding Relay",
  dsa_smackdown: "DSA Smackdown",
  technoseek: "Technoseek",
  prompt_wars: "Prompt Wars",
};

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Akshat-Raj
Akshat-Raj merged commit 776ade2 into Genesis-ISE-DSCE:main Apr 14, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants