forked from Generality-Labs/inspect-evals-template
-
Notifications
You must be signed in to change notification settings - Fork 1
Add all scorers for LABBench2 [3/n] #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
d57f3d2
Add recall judge and enable dbqa2
iphan 8164c0d
Add exact-match judge and enable figure/table/supplement tags
iphan 4f335ab
Port cloning scorer and enable the cloning tag
iphan 5f10e17
Tidy cloning scorer and add unit tests
iphan fecb9f3
Don't parse verdicts from code-like grader output
iphan efe825a
Port seqqa2 scorer and enable the seqqa2 tag
iphan a5e4e06
Tidy seqqa2 scorer, extract answer helpers, add tests
iphan cd7f600
Ask structured-output from LLM judge with regex fallback
iphan a1694d9
Pass answer in the cloning scorer output
iphan 224c4fa
Apply README suggestions from code review
iphan bf2d357
Update readme and add more debugging to scorer
iphan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question - is figqa2-img and figqa2-pdf subsets of figqa2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading forward ^ doesn't seem to be right. It could be worth explaining what the relationship between these tags are - are they made up of the same questions with just different data files? are they subsets?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is explained in section 2.1 of the paper. How much of the paper's info do you typically add to this README?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for commenting the section! The amount of info I add into the README is usually what is needed to run and interpret the eval results - I didn't read the paper in depth so it was a point of confusion on my end was what combination of tags to run.
I also get that a bloated README is also unhelpful, so I think you with what you think.