Skip to content

Make model_config more consistent#19

Open
MattFisher wants to merge 4 commits into
mainfrom
regenerate-dashboard-logs
Open

Make model_config more consistent#19
MattFisher wants to merge 4 commits into
mainfrom
regenerate-dashboard-logs

Conversation

@MattFisher

Copy link
Copy Markdown
Collaborator

Need a review on this one before regenerating the dashboard logs

@eleweek eleweek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, but requires fixing the tests

celiawaggoner
celiawaggoner previously approved these changes Apr 30, 2025

@celiawaggoner celiawaggoner left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove https://github.com/ArcadiaImpact/inspect_evals_scoring/pull/19/files#diff-d77ad65e926a80f1c601cea082ce57e74896a5d447a07b845d73dddf123d22faR208-R223 or update it so that whenever we do un-comment it, it's correct

looks good to me, with the one suggested above about the commented code

@MattFisher

MattFisher commented Apr 30, 2025

Copy link
Copy Markdown
Collaborator Author

Okay so the .dashboard.json files are now all updates in the stage folder, so should be showing up on the staging dashboard at https://inspect-evals-dashboard-stage.streamlit.app/ , but the values don't seem to have updated yet so I think they're still cached.

Once we've QA'd the staging site we can move the updated logs across to the prod folder in the S3 bucket.

(A good check is that the "API Provider" for Anthropic models has changed from "Anthropic (via AWS Bedrock & Anthropic API)" to just "Anthropic")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants