test(fx): address CodeRabbit nits on conservation tests#261
Conversation
- Op test-helper tuples now use decimal strings (Money = string) instead of JS number literals, honoring the Financial Precision rule (never Number for amounts/rates). toEvents already wraps each in new Decimal(...); figures are numerically identical (160.00/320.00/... unchanged). - The DIAGNOSTIC-ONLY test now exercises BOTH branches its title promises: it forces a real fx.conservation_mismatch via BreakableEngine and asserts the disposals/gain stay byte-identical after emission. Test-only; no production code or tax figure changes.
|
Warning Review limit reached
More reviews will be available in 40 minutes and 50 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Addresses both CodeRabbit findings on #260 (test-only, no production change):
Ophelper tuples typed amounts/rates as JSnumber; now decimal strings (Money = string), honoring the repo's Financial Precision rule (neverNumberfor amounts/rates).toEventsalready wraps each innew Decimal(...), so all figures are numerically identical (160.00/320.00/680.00… unchanged).fx.conservation_mismatchviaBreakableEngineand asserts the disposals/gain stay byte-identical after emission.Verified:
typecheck:testsclean,lintclean, conservation suite 19/19. No engine or tax-figure change.