fix: compute_additional_segment directions - #509
Merged
Merged
Conversation
zzzzzbk
requested review from
armantekinalp,
bhosale2 and
skim0119
as code owners
October 14, 2025 15:21
Collaborator
|
@zzzzzbk Could you remove the changes from |
Contributor
Author
|
@skim0119 Hi, I have reverted changes to those files. Thanks. |
skim0119
approved these changes
Oct 17, 2025
skim0119
left a comment
skim0119
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. I'm rebasing the branch; cleaning up some commits.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #507
The direction of end/start is not properly saved and causes results affected by the final timestep.
test_knot_theory: Add a second timestep to the additional segment straight case to test the independence from time.